Remove kolla_build_customizations_rocky defaults in Zed. #638
+21
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assumptionsandg
force-pushed
the
zed-remove-kbcr
branch
from
f6ee341 to
166adf1
Compare
Alex-Welsh
reviewed
Sep 13, 2023
assumptionsandg
force-pushed
the
zed-remove-kbcr
branch
from
166adf1 to
a3c9dbd
Compare
markgoddard
reviewed
Sep 14, 2023
assumptionsandg
force-pushed
the
zed-remove-kbcr
branch
2 times, most recently
from
53fb127 to
7b5ef52
Compare
markgoddard
reviewed
Sep 14, 2023
| @@ -89,3 +89,6 @@ stackhpc_docker_registry_password: !vault | | |||
| # Username and password of the overcloud host image repository. | |||
| stackhpc_image_repository_username: "{{ stackhpc_docker_registry_username }}" | |||
| stackhpc_image_repository_password: "{{ stackhpc_docker_registry_password }}" | |||
|
|
|||
| # SELinux set to disabled mode. | |||
| selinux_state: disabled | |||
There was a problem hiding this comment.
This needs to go in etc/kayobe/environments/ci-builder/kolla/globals.yml. I'm adding it in #626 so you could remove if you like.
assumptionsandg
force-pushed
the
zed-remove-kbcr
branch
from
7b5ef52 to
1b1a229
Compare
|
LGTM. Ready for review? |
Going to run some tests first, once they pass I'll open it. |
assumptionsandg
force-pushed
the
zed-remove-kbcr
branch
from
1b1a229 to
7895d9a
Compare
|
Incorporated this into #654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.